To: vim_dev@googlegroups.com Subject: Patch 8.2.0789 Fcc: outbox From: Bram Moolenaar Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ------------ Patch 8.2.0789 Problem: Vim9: expression testing lost coverage using constants. Solution: Use a few variables instead of constants. Files: src/testdir/test_vim9_expr.vim *** ../vim-8.2.0788/src/testdir/test_vim9_expr.vim 2020-05-15 22:01:51.284965534 +0200 --- src/testdir/test_vim9_expr.vim 2020-05-18 13:37:06.970522100 +0200 *************** *** 153,161 **** --- 153,165 ---- " test == comperator def Test_expr4_equal() + let trueVar = true + let falseVar = false assert_equal(true, true == true) assert_equal(false, true == false) + assert_equal(true, true == trueVar) + assert_equal(false, true == falseVar) assert_equal(true, true == g:atrue) assert_equal(false, g:atrue == false) *************** *** 164,171 **** --- 168,179 ---- assert_equal(true, g:anone == v:none) assert_equal(false, v:none == g:anull) + let nr0 = 0 + let nr61 = 61 assert_equal(false, 2 == 0) + assert_equal(false, 2 == nr0) assert_equal(true, 61 == 61) + assert_equal(true, 61 == nr61) assert_equal(true, g:anint == 10) assert_equal(false, 61 == g:anint) *************** *** 237,245 **** --- 245,257 ---- " test != comperator def Test_expr4_notequal() + let trueVar = true + let falseVar = false assert_equal(false, true != true) assert_equal(true, true != false) + assert_equal(false, true != trueVar) + assert_equal(true, true != falseVar) assert_equal(false, true != g:atrue) assert_equal(true, g:atrue != false) *************** *** 248,255 **** --- 260,271 ---- assert_equal(false, g:anone != v:none) assert_equal(true, v:none != g:anull) + let nr55 = 55 + let nr0 = 55 assert_equal(true, 2 != 0) + assert_equal(true, 2 != nr0) assert_equal(false, 55 != 55) + assert_equal(false, 55 != nr55) assert_equal(false, g:anint != 10) assert_equal(true, 61 != g:anint) *************** *** 313,318 **** --- 329,340 ---- 1) assert_false(2 > 2) assert_false(2 > 3) + let nr2 = 2 + assert_true(nr2 > 0) + assert_true(nr2 > + 1) + assert_false(nr2 > 2) + assert_false(nr2 > 3) if has('float') let ff = 2.0 assert_true(ff > 0.0) *************** *** 328,333 **** --- 350,359 ---- assert_true(2 >= 2) assert_false(2 >= 3) + let nr2 = 2 + assert_true(nr2 >= 0) + assert_true(nr2 >= 2) + assert_false(nr2 >= 3) if has('float') let ff = 2.0 assert_true(ff >= 0.0) *************** *** 342,347 **** --- 368,377 ---- assert_false(2 < 2) assert_true(2 < 3) + let nr2 = 2 + assert_false(nr2 < 0) + assert_false(nr2 < 2) + assert_true(nr2 < 3) if has('float') let ff = 2.0 assert_false(ff < 0.0) *************** *** 357,362 **** --- 387,397 ---- 1) assert_true(2 <= 2) assert_true(2 <= 3) + let nr2 = 2 + assert_false(nr2 <= 0) + assert_false(nr2 <= 1) + assert_true(nr2 <= 2) + assert_true(nr2 <= 3) if has('float') let ff = 2.0 assert_false(ff <= 0.0) *** ../vim-8.2.0788/src/version.c 2020-05-17 23:34:37.576176126 +0200 --- src/version.c 2020-05-18 13:30:45.111431645 +0200 *************** *** 748,749 **** --- 748,751 ---- { /* Add new patch number below this line */ + /**/ + 789, /**/ -- I'm writing a book. I've got the page numbers done. /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///